add generator to tsvector type #655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachdaniel
reviewed
Nov 21, 2025
Contributor
zachdaniel
left a comment
There was a problem hiding this comment.
This is reasonable for now, doesn't hurt, but we may eventually want to figure out some way to do it in a more realistic way etc.
rgraff
added a commit
that referenced
this pull request
Dec 10, 2025
…tributes * main: (23 commits) fix: do not build query filter with or: [] when all records are successfully inserted, for return_skipped_upsert?: true (#659) test: load aggregate with select and sort on from_many relationship (#661) test: add failing test for expr(has_one.function_calc) nil poisoning in batch (#660) test: aggregate with parent ref in relationship filter and sorting on relationship field (#658) test: binding error when loading aggregate (#657) chore(deps): bump ash_sql in the production-dependencies group (#656) test: multi relationship problems (#654) chore: release version v2.6.26 chore: update ash_sql, use new select binding test: add complex calculation tests with filtered aggregates (#652) improvement: add generator to tsvector type (#655) test: add failing test for aggregate filtering on nested first aggregate (#653) chore: update ash_sql and add test docs: Mention :define_ecto_repo? option of use AshPostgres.Repo macro in getting started guide (#648) improvement: verify check constraint attributes at compile time chore: update ash chore: reuse compliance improvement: update deps for bug fixes chore: release version v2.6.25 test: Add failing test for aggregate with parent() + select() + limit() (#644) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My team uses the Tsvector type, and we're trying to start using generators in tests, but tsvector currently doesn't have a generator so trying to generate something with it raises. This adds one that just always creates an empty list. I'm open to suggestions if you think the generator should be doing something more complex here—I assume this is a scenario where, if someone wants to be generating something specific for it in a test, they probably have a clear idea of what that is.
Contributor checklist
Leave anything that you believe does not apply unchecked.