Skip to content

BTS-2184 Fix vector index creation fails when documents don't have embedding field #21873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 25, 2025
Merged

BTS-2184 Fix vector index creation fails when documents don't have embedding field #21873

merged 12 commits into from
Jul 25, 2025

Conversation

jbajic
Copy link
Contributor

@jbajic jbajic commented Jul 21, 2025 •
edited
Loading

Scope & Purpose

Vector index creation fails on documents that don't have an embedding field defined, even whenthe index is sparse. Now these documents are being ignored and are not handled by the vector index.

  • 💩 Bugfix
  • 🍕 New feature
  • 🔥 Performance improvement
  • 🔨 Refactoring/simplification

Checklist

  • Tests
    • Regression tests
    • C++ Unit tests
    • integration tests
    • resilience tests
  • 📖 CHANGELOG entry made
  • 📚 documentation written (release notes, API changes, ...)
  • Backports
    • Backport for 3.12.0: (Please link PR)
    • Backport for 3.11: (Please link PR)
    • Backport for 3.10: (Please link PR)

Related Information

(Please reference tickets / specification / other PRs etc)

@jbajic jbajic self-assigned this Jul 21, 2025
@cla-bot cla-bot bot added the cla-signed label Jul 21, 2025
@jbajic jbajic changed the title Bug fix/bts 2184 BTS-2184 Fix vector index creation fails when documents don't have embedding field Jul 21, 2025
goedderz
goedderz previously requested changes Jul 23, 2025
View reviewed changes
Copy link
Member

@goedderz goedderz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not looked into the details yet, so I might be wrong. But it seems to me, intuitively, that this is sensible behavior, and we only want to ignore documents this way for sparse indexes. Let's please discuss this shortly before merging!

@goedderz goedderz dismissed their stale review July 23, 2025 08:31

Discussed and agreed, dismissing the review so it can be merged later while I'm out.

kvahed
kvahed approved these changes Jul 25, 2025
View reviewed changes
Copy link
Contributor

@kvahed kvahed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kvahed kvahed merged commit 6e874b7 into devel Jul 25, 2025
7 checks passed
@kvahed kvahed deleted the bug-fix/bts-2184 branch July 25, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvahed kvahed kvahed approved these changes

@goedderz goedderz goedderz left review comments

Assignees

@jbajic jbajic

Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbajic @kvahed @goedderz