refactor(service-worker): improve localhost detection in scheduleInit… #62861
+109
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0c85c8c to
0c2409d
Compare
JoostK
reviewed
Jul 29, 2025
Comment on lines
942
to
958
| private isLocalhost(): boolean { | ||
| return /(localhost|\[::1\]|127(?:\.\d{1,3}){3})(:\d+)?\/?$/.test(this.scope.registration.scope); | ||
| } |
There was a problem hiding this comment.
I'd suggest pulling this out into a top-level function that takes the scope as parameter, such that you can add tests for this logic.
Also the regex can be adjusted to not have any capturing groups:
Suggested change
| private isLocalhost(): boolean { | |
| return /(localhost|\[::1\]|127(?:\.\d{1,3}){3})(:\d+)?\/?$/.test(this.scope.registration.scope); | |
| } | |
| private isLocalhost(): boolean { | |
| return /(?:localhost|\[::1\]|127(?:\.\d{1,3}){3})(?::\d+)?\/?$/.test(this.scope.registration.scope); | |
| } |
Q should the localhost case be prefixed with something like \W to require a non-word in front of it?
There was a problem hiding this comment.
I think so, I just updated with some improvements and tests.
2d7c4c6 to
26c75b0
Compare
…ialization Replaces ad hoc localhost check with a dedicated method using a regular expression for more reliable detection
26c75b0 to
e52f071
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace simple string search with comprehensive regex pattern that detects:
Extract logic into dedicated isLocalhost() method for better code organization
and remove existing TODO comment.