refactor(devtools): add property show graph button #62853
Draft
+275
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add "Show graph" button to the signal properties in the side pane.
JeanMeche
reviewed
Jul 28, 2025
| [currentSelectedElement]="currentSelectedElement" | ||
| [signalGraphEnabled]="signalGraphEnabled()" |
There was a problem hiding this comment.
Instead of prop drilling, should we extract that into a service since this is more or less a global state ?
There was a problem hiding this comment.
Totally agree, but I think it makes sense to introduce that after #62429 is merged (or as part of it depending which PR is merged first). The Settings service will take care of it.
36b2ea2 to
af61074
Compare
af61074 to
bccd2bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WORK IN PROGRESS
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the new behavior?
Add "Show graph" button to the signal properties in the side pane. Ref: milomg#1