refactor(signal-forms): cleanup for api/logic & api/structure #62810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonsenft
approved these changes
Jul 25, 2025
In practice I found the ability to return false quite confusing. It meant you could do `x && ValidationError.custom()`, but not `x || ValidationError.custom()`. Making both of those work would mean that returning `true` from `validate` vs returning `false` would mean the exact same thing (no errors). That's also super odd, so I opted to just remove `false` as a possibility.
132e6ec to
7210c08
Compare
21ca05d
into
angular:prototype/signal-forms
10 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.