fix(core): switch check to documentElement with chaining #62773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

thePunderWoman wants to merge 1 commit into angular:main from thePunderWoman:animation-document

Contributor

thePunderWoman commented Jul 23, 2025

This fixes a situation where DOM checks may report null.

thePunderWoman added action: review area: core target: minor labels

ngbot bot modified the milestone: Backlog

kirjs approved these changes

View reviewed changes

kirjs added action: merge and removed action: review labels

JeanMeche reviewed

View reviewed changes

packages/core/src/render3/instructions/animation.ts Show resolved Hide resolved


          fix(core): switch check to documentElement with chaining

45fcbda

This fixes a situation where DOM checks may report null.

thePunderWoman force-pushed the animation-document branch from 91d762c to 45fcbda Compare

July 23, 2025 18:26

Contributor

kirjs commented Jul 23, 2025

This PR was merged into the repository by commit 063b5e1.

The changes were merged into the following branches: main

kirjs closed this in

063b5e1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge area: core target: minor