fix(compiler): incorrect spans for left side of binary operation #62641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

crisbeto wants to merge 1 commit into angular:main from crisbeto:62617/binary-spans

+36 −6

Member

crisbeto commented Jul 15, 2025

Fixes that the span for the left side of a Binary AST included the range up to and including the operator.

Fixes #62617.

crisbeto added target: patch action: review labels

angular-robot bot added the area: compiler label

ngbot bot added this to the Backlog milestone

JoostK approved these changes

View reviewed changes


          fix(compiler): incorrect spans for left side of binary operation

1a693b1

Fixes that the span for the `left` side of a `Binary` AST included the range up to and including the operator.

Fixes angular#62617.

crisbeto force-pushed the 62617/binary-spans branch from 4867ecd to 1a693b1 Compare

July 15, 2025 09:16

crisbeto added action: merge and removed action: review labels

Contributor

AndrewKushnir commented Jul 15, 2025

This PR was merged into the repository by commit a1e3f2b.

The changes were merged into the following branches: main, 20.1.x

AndrewKushnir closed this in

a1e3f2b

AndrewKushnir pushed a commit that referenced this pull request


          fix(compiler): incorrect spans for left side of binary operation (#62641

75d2a34

)

Fixes that the span for the `left` side of a `Binary` AST included the range up to and including the operator.

Fixes #62617.

PR Close #62641

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge area: compiler target: patch