Skip to content

fix(core): Fixed InputBinding behavior when a property set to @Input and cdr strategy OnPush #62613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(core): Fixed InputBinding behavior when a property set to @Input and cdr strategy OnPush #62613

wants to merge 1 commit into from

Conversation

aparzi
Copy link
Contributor

@aparzi aparzi commented Jul 12, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

inputBinding to bind to an old-style @input() property of an OnPush component doesn't mark the component for check and therefore never updates the template of that component.

Issue Number: #62343

What is the new behavior?

Fixed InputBinding behavior when a property set to @input and a component with cdr strategy set to OnPush would never update the component view

Does this PR introduce a breaking change?

  • Yes
  • No

@pullapprove pullapprove bot requested a review from thePunderWoman July 12, 2025 22:09
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Jul 12, 2025
@ngbot ngbot bot added this to the Backlog milestone Jul 12, 2025
@JeanMeche JeanMeche requested review from crisbeto and atscott and removed request for thePunderWoman July 12, 2025 22:15
@aparzi aparzi force-pushed the fix-issue-62343 branch from 6091e73 to 5b6dc93 Compare July 12, 2025 23:12
crisbeto
crisbeto reviewed Jul 13, 2025
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, but I'll defer to @atscott since he knows this part of the framework better.

@JeanMeche JeanMeche added target: patch This PR is targeted for the next patch release action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jul 14, 2025
@JeanMeche
Copy link
Member

JeanMeche commented Jul 14, 2025 •
edited
Loading

Can you please make sure to add a commit body, Thank you.

@aparzi @JeanMeche
fix(core): InputBinding marks component a dirty.
800f748 
This fix ensures that CD runs on OnPush component when an input binding is set.
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jul 14, 2025
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 780774f.

The changes were merged into the following branches: main, 20.1.x

AndrewKushnir pushed a commit that referenced this pull request Jul 14, 2025
@aparzi @AndrewKushnir
fix(core): InputBinding marks component a dirty. (#62613)
a81f0fa 
This fix ensures that CD runs on OnPush component when an input binding is set.

PR Close #62613
@ajafff ajafff mentioned this pull request Jul 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crisbeto crisbeto crisbeto left review comments

@atscott atscott atscott approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
5 participants
@aparzi @JeanMeche @AndrewKushnir @atscott @crisbeto