Skip to content

docs(docs-infra): updated best practices component doc #62599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs(docs-infra): updated best practices component doc #62599

wants to merge 1 commit into from

Conversation

akib1997
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from alan-agius4 July 11, 2025 21:30
@angular-robot angular-robot bot added area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure labels Jul 11, 2025
@ngbot ngbot bot added this to the Backlog milestone Jul 11, 2025
@JeanMeche JeanMeche requested review from MarkTechson and AndrewKushnir and removed request for alan-agius4 July 11, 2025 21:32
@JeanMeche JeanMeche added the ai Issue related to using AI agents label Jul 11, 2025
JeanMeche
JeanMeche reviewed Jul 11, 2025
View reviewed changes
adev/src/context/best-practices.md Outdated
- Use `input()` and `output()` functions instead of decorators
- Use `signal()` for local state
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably a duplicate with the state management rule below.

@AndrewKushnir AndrewKushnir self-assigned this Jul 11, 2025
@pullapprove pullapprove bot requested a review from josephperrott July 12, 2025 05:53
@akib1997 akib1997 force-pushed the update/best-practice-components branch from ae4ace8 to c327a89 Compare July 12, 2025 06:14
@JeanMeche JeanMeche removed the request for review from josephperrott July 12, 2025 11:05
thePunderWoman
thePunderWoman approved these changes Jul 24, 2025
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thePunderWoman thePunderWoman added the target: patch This PR is targeted for the next patch release label Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeanMeche JeanMeche JeanMeche left review comments

@thePunderWoman thePunderWoman thePunderWoman approved these changes

@MarkTechson MarkTechson Awaiting requested review from MarkTechson

@AndrewKushnir AndrewKushnir Awaiting requested review from AndrewKushnir

Assignees

@AndrewKushnir AndrewKushnir

Labels
action: discuss ai Issue related to using AI agents area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
4 participants
@akib1997 @JeanMeche @thePunderWoman @AndrewKushnir