fix(router): ensure preloaded components are properly activated #62502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
reviewed
Jul 7, 2025
atscott
approved these changes
Jul 8, 2025
atscott
reviewed
Jul 8, 2025
Comment on lines
828
to
841
| loadComponent: () => of(LazyLoadedStandaloneComponent).pipe(delay(100)), | ||
| canActivate: [() => of(true).pipe(delay(200))], | ||
| }, | ||
| ]); | ||
|
|
||
| router.navigateByUrl('/blank'); | ||
|
|
||
| await advance(fixture); | ||
|
|
||
| routerPreloader.preload(); | ||
|
|
||
| router.navigateByUrl('/lazy'); | ||
|
|
||
| await advance(fixture, 400); |
There was a problem hiding this comment.
Do these delays need to be so large? This test will take half a second, which seems unnecessarily long
There was a problem hiding this comment.
It appears that such large delays are unnecessary. The delays have been reduced
Preloaded components were not being activated in certain scenarios when preloading was enabled. This change ensures that components are correctly activated after being preloaded.
2803c39 to
b3f5756
Compare
|
This PR was merged into the repository by commit 9c45c32. The changes were merged into the following branches: main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
This PR addresses an issue where preloaded components are not being activated as expected when preloading is enabled. In certain scenarios, the preloading strategy loads the component, but the route activation does not occur, resulting in the component not being displayed to the user.
What is the new behavior?
This change aims to ensure that preloaded components are properly activated after being loaded.
Does this PR introduce a breaking change?
Other information
Please review this simplified example, which demonstrates the issue. In our production application, we encountered this problem in a more complex scenario: https://stackblitz.com/edit/stackblitz-starters-u44n3ca2?file=package.json