Skip to content

fix bug while generating description in spl-rule #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexvolha merged 1 commit into from
Dec 6, 2023
Merged

fix bug while generating description in spl-rule #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix bug while generating description in spl-rule
  • Loading branch information
@dtsprm
dtsprm committed Dec 6, 2023
commit ddeb57aa2b73cc30fe971fa01dec0b6ef0cb5cd6
6 changes: 1 addition & 5 deletions siem-converter/app/converter/platforms/splunk/renders/splunk_alert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,9 @@ def finalize_query(self, prefix: str, query: str, functions: str, meta_info: Met
rule = rule.replace("<severity_place_holder>", severity_map.get(meta_info.severity, "1"))
rule_description = get_rule_description_str(
description=meta_info.description or 'Autogenerated Splunk Alert.',
license=meta_info.license,
mitre_attack=meta_info.mitre_attack
license=meta_info.license
)
rule = rule.replace("<description_place_holder>", rule_description)

description = f"{meta_info.description or 'Autogenerated Splunk Alert.'} License: {meta_info.license}."
rule = rule.replace("<description_place_holder>", description)
mitre_techniques = self.__create_mitre_threat(meta_info=meta_info)
if mitre_techniques:
mitre_str = f"action.correlationsearch.annotations = {mitre_techniques})"
Expand Down