Skip to content

fix: add check to see in ownerSymbol parent is the global symbol #1472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
starsprung wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: add check to see in ownerSymbol parent is the global symbol #1472

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/transformation/builtins/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@ function tryTransformBuiltinGlobalMethodCall(
) {
const ownerType = context.checker.getTypeAtLocation(calledMethod.expression);
const ownerSymbol = tryGetStandardLibrarySymbolOfType(context, ownerType);
if (!ownerSymbol || ownerSymbol.parent) return;
Copy link
Member

@Perryvw Perryvw Aug 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if instead we shouldn't just be removing this ownerSymbol.parent, not really sure if it adds anything

if (!ownerSymbol || (ownerSymbol.parent && context.checker.getFullyQualifiedName(ownerSymbol.parent) !== "global"))
return;

let result: lua.Expression | undefined;
switch (ownerSymbol.name) {
Expand Down