Skip to content

#6438 Improvement of Hamming Distance class #6447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

#6438 Improvement of Hamming Distance class #6447

wants to merge 7 commits into from

Conversation

dinishajais
Copy link
Contributor

Issue #6438
I have created abstract class HammingHandler for managing various checks as per demanded in the issue raised. Also I have created additional test classes that would test the new classes created.

👍 I have read [CONTRIBUTING.md]
👍 This pull request is all my own work -- I have not plagiarized it.
👍 All filenames are in PascalCase.
👍 All functions and variable names follow Java naming conventions.
👍 All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
👍 All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.06%. Comparing base (24f4090) to head (086ca72).

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #6447      +/-   ##
============================================
+ Coverage     75.04%   75.06%   +0.01%     
- Complexity     5534     5543       +9     
============================================
  Files           685      689       +4     
  Lines         19208    19219      +11     
  Branches       3706     3707       +1     
============================================
+ Hits          14414    14426      +12     
  Misses         4239     4239              
+ Partials        555      554       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dinishajais
Copy link
Contributor Author

I have tried resolving the formatting multiple times , but it seems each time I change the formatting it asks me to revert back the changes. Though there are no errors in here, only a formatting issue. Please give it a check once.

@DenizAltunkapan
Copy link
Collaborator

Please install the clang-formatter locally, e.g. on linux sudo apt install clang-format
After that run the following command find src -name "*.java" -exec clang-format -i -style=file {} +
For other OS, you have to do some research (https://clang.llvm.org/docs/ClangFormat.html)

@dinishajais
Copy link
Contributor Author

Thank you for the help. @DenizAltunkapan

@dinishajais dinishajais deleted the 6438/ImprovementForHammingDistance branch July 27, 2025 19:35
@dinishajais dinishajais restored the 6438/ImprovementForHammingDistance branch July 27, 2025 19:42
@dinishajais dinishajais reopened this Jul 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenizAltunkapan DenizAltunkapan Awaiting requested review from DenizAltunkapan DenizAltunkapan is a code owner

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@vil02 vil02 Awaiting requested review from vil02 vil02 is a code owner

@alxkm alxkm Awaiting requested review from alxkm alxkm is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dinishajais @codecov-commenter @DenizAltunkapan