Skip to content

nt.terminalsize #6374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 2 commits into from
Dec 9, 2025
+37 −20
Merged

nt.terminalsize #6374

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7384782
terminalsize
youknowone Dec 8, 2025
9acfc46
use _get_osfhandle
youknowone Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 37 additions & 20 deletions crates/vm/src/stdlib/nt.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,32 +203,49 @@ pub(crate) mod module {
fd: OptionalArg<i32>,
vm: &VirtualMachine,
) -> PyResult<_os::TerminalSizeData> {
let (columns, lines) = {
let stdhandle = match fd {
OptionalArg::Present(0) => Console::STD_INPUT_HANDLE,
OptionalArg::Present(1) | OptionalArg::Missing => Console::STD_OUTPUT_HANDLE,
OptionalArg::Present(2) => Console::STD_ERROR_HANDLE,
_ => return Err(vm.new_value_error("bad file descriptor")),
};
let h = unsafe { Console::GetStdHandle(stdhandle) };
if h.is_null() {
return Err(vm.new_os_error("handle cannot be retrieved".to_owned()));
let fd = fd.unwrap_or(1); // default to stdout

// Use _get_osfhandle for all fds
let borrowed = unsafe { crt_fd::Borrowed::borrow_raw(fd) };
let handle = crt_fd::as_handle(borrowed).map_err(|e| e.to_pyexception(vm))?;
let h = handle.as_raw_handle() as Foundation::HANDLE;

let mut csbi = MaybeUninit::uninit();
let ret = unsafe { Console::GetConsoleScreenBufferInfo(h, csbi.as_mut_ptr()) };
if ret == 0 {
// Check if error is due to lack of read access on a console handle
// ERROR_ACCESS_DENIED (5) means it's a console but without read permission
// In that case, try opening CONOUT$ directly with read access
let err = unsafe { Foundation::GetLastError() };
if err != Foundation::ERROR_ACCESS_DENIED {
return Err(errno_err(vm));
}
if h == INVALID_HANDLE_VALUE {
let conout: Vec<u16> = "CONOUT$\0".encode_utf16().collect();
let console_handle = unsafe {
FileSystem::CreateFileW(
conout.as_ptr(),
Foundation::GENERIC_READ | Foundation::GENERIC_WRITE,
FileSystem::FILE_SHARE_READ | FileSystem::FILE_SHARE_WRITE,
std::ptr::null(),
FileSystem::OPEN_EXISTING,
0,
std::ptr::null_mut(),
)
};
if console_handle == INVALID_HANDLE_VALUE {
return Err(errno_err(vm));
}
let mut csbi = MaybeUninit::uninit();
let ret = unsafe { Console::GetConsoleScreenBufferInfo(h, csbi.as_mut_ptr()) };
let csbi = unsafe { csbi.assume_init() };
let ret =
unsafe { Console::GetConsoleScreenBufferInfo(console_handle, csbi.as_mut_ptr()) };
unsafe { Foundation::CloseHandle(console_handle) };
if ret == 0 {
return Err(errno_err(vm));
}
let w = csbi.srWindow;
(
(w.Right - w.Left + 1) as usize,
(w.Bottom - w.Top + 1) as usize,
)
};
}
let csbi = unsafe { csbi.assume_init() };
let w = csbi.srWindow;
let columns = (w.Right - w.Left + 1) as usize;
let lines = (w.Bottom - w.Top + 1) as usize;
Ok(_os::TerminalSizeData { columns, lines })
}

Expand Down
Loading