removed old auto-format implimentaion from ci.yaml #6251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

youknowone merged 1 commit into RustPython:main from YashSuthar983:chore/ci-autoformat

Nov 10, 2025

Contributor

YashSuthar983 commented Nov 10, 2025 •

edited

Loading

@youknowone @fanninpm i forget to remove old one , apologies for my carelessness.

issues:#6248 failed due to this.

Summary by CodeRabbit

Release Notes

Chores
- Removed the automatic code formatting job from the continuous integration pipeline.


          remove old auto-formte implimentaion

e5bcfb8

Signed-off-by: Yash Suthar <yashsuthar983@gmail.com>

Contributor

coderabbitai bot commented Nov 10, 2025 •

edited

Loading

Walkthrough

Removed the auto_format_commit GitHub Actions job from the CI workflow. This deletion eliminates automatic code formatting functionality, including Rust toolchain setup for rustfmt, cargo fmt execution, git commit/push operations, and PR commenting steps from the continuous integration pipeline.

Changes

Cohort / File(s)	Change Summary
CI Workflow Formatting Job Removal `\.github/workflows/ci\.yaml`	Removed the entire `auto_format_commit` job including checkout, Rust toolchain setup, rustfmt execution, git operations, conditional gating, concurrency configuration, and PR commenting steps

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Review workflow file structure to confirm complete removal of the job and its dependencies
Verify no orphaned references or conditional logic depend on the removed job outputs

Possibly related PRs

Revert "Update CI auto-format" #6236: Modifies CI formatting workflows—removes auto_format job while adjusting ci.yaml rustfmt integration
Update CI auto-formate #6237: Directly related as this PR undoes the auto-format CI job modifications that PR introduced
Update CI auto-format #6233: Modifies the same CI formatting functionality in .github/workflows with complementary workflow and linting changes

Suggested reviewers

youknowone

Poem

🐰 No more auto-format running free,
The workflow's cleaned up, as it should be!
Rustfmt steps removed with care,
CI flows leaner through the air! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: removing an old auto-format implementation from the CI workflow file.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

YashSuthar983 changed the title ~~removed old auto-formte implimentaion from ci.yaml~~ removed old auto-format implimentaion from ci.yaml

ShaharNaveh approved these changes

View reviewed changes

Collaborator

ShaharNaveh left a comment

ty:)

youknowone merged commit 0f8c0bc into RustPython:main

13 checks passed

coderabbitai bot mentioned this pull request

Auto-format before checks #6275

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet