-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Implement minimal builtins.anext() #6226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incomplete default value handling makes the function only partially functional.
The
default_valueparameter is accepted but completely ignored—both branches return the sameawaitableregardless of whether a default is provided. This causes the function to fail the second use case described in the PR objectives: when the async iterator is exhausted and a default value is provided, RustPython raisesStopAsyncIterationinstead of returning the default like CPython does.While the TODO comment acknowledges this limitation, having a function signature that accepts a parameter it cannot honor is problematic because:
default_valuecreates a false sense of functionalityConsider one of these approaches before merging:
Option 1 (preferred if feasible): Complete the implementation by adding
PyAnextAwaitableto wrap the awaitable and handle the default value case.Option 2: Reject the default parameter explicitly until support is implemented:
#[pyfunction] fn anext( aiter: PyObjectRef, default_value: OptionalArg<PyObjectRef>, vm: &VirtualMachine, ) -> PyResult { let awaitable = vm.call_method(&aiter, "__anext__", ())?; - if default_value.is_missing() { - Ok(awaitable) - } else { - // TODO: Implement CPython like PyAnextAwaitable to properly handle the default value. - Ok(awaitable) + if let OptionalArg::Present(_) = default_value { + Err(vm.new_not_implemented_error( + "anext() with default value is not yet implemented".to_owned() + )) + } else { + Ok(awaitable) } }Option 3: Defer merging this PR until the default value handling is fully implemented.
📝 Committable suggestion