stdlib/src/sqlite.rs (2)

900-910: Clamp timeout to avoid c_int overflow

let timeout = (args.timeout * 1000.0) as c_int; can overflow for large timeouts. Clamp and round before casting.

Apply within this block:

-            let timeout = (args.timeout * 1000.0) as c_int;
-            db.busy_timeout(timeout);
+            // Saturate to c_int::MAX and avoid negatives
+            let timeout_ms = (args.timeout * 1000.0).clamp(0.0, i32::MAX as f64).round() as c_int;
+            db.busy_timeout(timeout_ms);

---

911-922: Subclass init path: good; consider making sqlite.connect() call the factory so init runs

__init__ correctly performs one-time DB open for subclassed instances. However, sqlite.connect() still constructs via Connection::py_new(...), so a factory=SubClass won’t execute the subclass’ __init__ (unlike CPython, which calls factory(...)). Recommend updating connect() to invoke the factory type, letting Python dispatch call __new__ then __init__.

Proposed approach (conceptual; outside this hunk): build args tuple matching ConnectArgs order and call the type:

// Pseudocode: call the chosen factory so __init__ runs for subclasses
// let obj = vm.invoke(args.factory.clone().into_object(),
//     (args.database, args.timeout, args.detect_types, args.isolation_level,
//      args.check_same_thread, /* omit passing 'factory' itself */
//      args.cached_statements, args.uri))?;

Please verify no downstream assumptions rely on the current “py_new-only” construction.

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro