Replace skips in test_importlib/source/test_file_loader with expectedFailures #6194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

youknowone merged 5 commits into RustPython:main from fanninpm:test-importlib-skips-go-bye-bye

Oct 20, 2025

Contributor

fanninpm commented Oct 18, 2025 •

edited

Loading

New trick learned: Did you know you can monkey-patch entire classes using this one simple trick? CPython developers hate this!

Summary by CodeRabbit

Summary? What summary?

fanninpm added 5 commits

October 17, 2025 22:26


          Replace skips with expectedFailure markings for SimpleTest

542d954


          Uncomment Source-PEP451 tests and apply similar monkey-patches as before

c87097f


          Uncomment Source-PEP302 tests and apply similar monkey-patches as before

422b13a


          Uncomment Sourceless-PEP451 tests and apply similar monkey-patches as

bbc87d9

before


          Uncomment Sourceless-PEP302 tests and apply similar monkey-patches as

b750b3e

before

Contributor

coderabbitai bot commented Oct 18, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)

Lib/test/test_importlib/source/test_file_loader.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

fanninpm assigned youknowone

youknowone approved these changes

View reviewed changes

Member

youknowone left a comment

👍

Contributor Author

fanninpm commented Oct 18, 2025

Windows CI failures are due to OpenSSL not building correctly. I have no idea what to do for the WASM CI failure.

Member

youknowone commented Oct 20, 2025

I have no idea too. But this patch doesn't seem to be related.

youknowone merged commit 3473d82 into RustPython:main

17 of 23 checks passed

fanninpm deleted the test-importlib-skips-go-bye-bye branch

October 21, 2025 00:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet