sqlite: Align Connection.call error handling with CPython #6042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

ever0de wants to merge 1 commit into RustPython:main from ever0de:fix/sqlite-closed-conn-call

Contributor

ever0de commented Jul 28, 2025 •

edited by coderabbitai bot

Loading

ref

https://github.com/python/cpython/blob/f66c75f11d3aeeb614600251fd5d3fe1a34b5ff1/Modules/_sqlite/connection.c#L1774-L1797

Summary by CodeRabbit

Refactor
- Improved handling of function arguments for database connections, allowing for more flexible input.
- Enhanced reliability by ensuring explicit locking during statement creation.


          sqlite: Align Connection.__call__ error handling with CPython

7a03188

Contributor

coderabbitai bot commented Jul 28, 2025 •

edited

Loading

Walkthrough

The Callable trait implementation for the Connection struct in the SQLite module was updated. The argument type was generalized from a tuple of PyStrRef to FuncArgs, and explicit database locking and argument unpacking were introduced before statement creation within the call method.

Changes

Cohort / File(s)	Change Summary
SQLite Callable Argument Handling `stdlib/src/sqlite.rs`	Changed `Callable` implementation for `Connection` to accept `FuncArgs` instead of `(PyStrRef,)`, added explicit locking and argument unpacking in the `call` method.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Suggested reviewers

youknowone

Poem

A lock on the database, a tuple unwrapped,
The arguments changed, the old code recapped.
Now FuncArgs march in, with flexibility new,
The rabbit approves—so much more you can do!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d8f1d18 and 7a03188.

⛔ Files ignored due to path filters (1)

Lib/test/test_sqlite3/test_dbapi.py is excluded by !Lib/**

📒 Files selected for processing (1)

stdlib/src/sqlite.rs (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**/*.rs

📄 CodeRabbit Inference Engine (.github/copilot-instructions.md)

**/*.rs: Follow the default rustfmt code style (cargo fmt to format)
Always run clippy to lint code (cargo clippy) before completing tasks. Fix any warnings or lints that are introduced by your changes
Follow Rust best practices for error handling and memory management
Use the macro system (pyclass, pymodule, pyfunction, etc.) when implementing Python functionality in Rust

Files:

stdlib/src/sqlite.rs

🔇 Additional comments (2)

stdlib/src/sqlite.rs (2)

854-854: LGTM: Type generalization aligns with CPython behavior

The change from (PyStrRef,) to FuncArgs provides more flexible argument handling that better matches CPython's Connection.__call__ method behavior.

856-866: LGTM: Improved error handling and argument validation

The implementation correctly handles the transition to FuncArgs with proper validation:

Database locking: Explicit lock acquisition ensures connection validity before processing

Argument binding: Proper extraction and validation of the SQL string parameter

Error handling: Maintains existing error propagation through ? operators

This change aligns with CPython's behavior while following RustPython's patterns for argument handling and thread safety.

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet