Skip to content

stdlib(sqlite): Raise ProgrammingError in closed Blob context manager #6041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2025
Merged

stdlib(sqlite): Raise ProgrammingError in closed Blob context manager #6041

merged 1 commit into from
Jul 27, 2025

Conversation

ever0de
Copy link
Contributor

@ever0de ever0de commented Jul 27, 2025 •
edited by coderabbitai bot
Loading

ref

Right now I'm discarding the return value of inner(). Should I extract this check into a separate helper function, like ensure_inner(), that just validates the state?

Summary by CodeRabbit

  • Bug Fixes
    • Improved error handling when using blobs as context managers, ensuring proper resource management and error reporting during entry and exit.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 27, 2025 •
edited
Loading

Walkthrough

The Blob class's context management methods in the SQLite module were updated to accept a VirtualMachine parameter and return PyResult types. Both __enter__ and __exit__ now perform error checking by invoking inner(vm)? before proceeding, ensuring the blob's state is validated during context management.

Changes

File(s) Change Summary
stdlib/src/sqlite.rs Updated Blob class's __enter__ and __exit__ method signatures to accept VirtualMachine, return PyResult, and perform error checking on blob state.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Blob
    participant VirtualMachine

    User->>Blob: __enter__(vm)
    Blob->>VirtualMachine: inner(vm)?
    VirtualMachine-->>Blob: Result (Ok/Error)
    Blob-->>User: PyResult<Blob>

    User->>Blob: __exit__(_args, vm)
    Blob->>VirtualMachine: inner(vm)?
    VirtualMachine-->>Blob: Result (Ok/Error)
    Blob->>Blob: close()
    Blob-->>User: PyResult<()>
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Suggested reviewers

  • youknowone

Poem

A blob in the database, snug and tight,
Now checks its state before day or night.
With context managed, errors in sight,
The code is robust—oh, what delight!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 89c58d6 and ac08f65.

⛔ Files ignored due to path filters (1)
  • Lib/test/test_sqlite3/test_dbapi.py is excluded by !Lib/**
📒 Files selected for processing (1)
  • stdlib/src/sqlite.rs (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.rs

📄 CodeRabbit Inference Engine (.github/copilot-instructions.md)

**/*.rs: Follow the default rustfmt code style (cargo fmt to format)
Always run clippy to lint code (cargo clippy) before completing tasks. Fix any warnings or lints that are introduced by your changes
Follow Rust best practices for error handling and memory management
Use the macro system (pyclass, pymodule, pyfunction, etc.) when implementing Python functionality in Rust

Files:

  • stdlib/src/sqlite.rs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
  • GitHub Check: Run snippets and cpython tests (macos-latest)
  • GitHub Check: Check Rust code with rustfmt and clippy
  • GitHub Check: Run rust tests (ubuntu-latest)
  • GitHub Check: Run snippets and cpython tests (ubuntu-latest)
  • GitHub Check: Run rust tests (macos-latest)
  • GitHub Check: Run snippets and cpython tests (windows-latest)
  • GitHub Check: Check the WASM package and demo
  • GitHub Check: Run snippets and cpython tests on wasm-wasi
  • GitHub Check: Run tests under miri
  • GitHub Check: Run rust tests (windows-latest)
  • GitHub Check: Ensure compilation on various targets
🔇 Additional comments (2)
stdlib/src/sqlite.rs (2)

2148-2151: LGTM! Proper error checking added to context manager entry.

The changes correctly implement the PR objective by adding blob state validation via inner(vm)? before allowing context manager entry. The method signature properly reflects that it can now fail with a PyResult, and the error handling aligns with CPython's behavior of raising ProgrammingError for closed blob operations.

2154-2158: LGTM! Consistent error checking added to context manager exit.

The changes properly validate the blob state before proceeding with cleanup operations. The inner(vm)? call ensures that ProgrammingError is raised if attempting to exit an already closed blob context, maintaining consistency with the __enter__ method. The method signature correctly reflects the new error-returning behavior.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@youknowone youknowone merged commit d8f1d18 into RustPython:main Jul 27, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone youknowone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ever0de @youknowone