Add `_socket` constants from CPython 3.10 #3840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

youknowone merged 6 commits into RustPython:main from fanninpm:socket-constants

Jul 6, 2022

Contributor

fanninpm commented Jul 4, 2022

The following constants may be missing from either rust's libc or the winapi crate (as of 4 July 2022):

fanninpm added 6 commits

July 4, 2022 18:34


          Add _socket constants from CPython 3.10

ca90bf3


          Fix compilation errors on macOS and Windows

4e87250


          Resolve ambiguous imports on Windows

97db885


          Mark erroring/failing tests

92f790e


          Mark erroring test on Windows

b39263d


          Unmark passing test on macOS and Windows

0b1a542

fanninpm marked this pull request as ready for review

July 5, 2022 01:22

Member

youknowone commented Jul 6, 2022

I think we can close #1176

youknowone linked an issue

that may be closed by this pull request

Extend the socket module #1176

Closed

youknowone approved these changes

View reviewed changes

youknowone merged commit 0aca6a8 into RustPython:main

fanninpm deleted the socket-constants branch

July 9, 2022 00:07

fanninpm mentioned this pull request

Add localeconv function to locale module #4558

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet