Format exceptions nicely (no more RefCell { value: .. }!) #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

windelbouwman merged 2 commits into RustPython:master from coolreader18:formatted-exceptions

Dec 27, 2018

Member

coolreader18 commented Dec 27, 2018

This required going through and changing all the instances of format!("{:?}", py_obj_ref) to format!("{}", py_obj_ref.borrow()), because I implemented it as the fmt::Display formatter and RefCell doesn't implement fmt::Display, so the values need to be borrowed to get the PyObject.

coolreader18 added 2 commits

December 26, 2018 18:09


          Format PyObject's correctly and nicely

80573b0


          Run cargo fmt

0ac0432

coolreader18 changed the title ~~Format exceptions nicely, no more RefCell { value: .. }!~~ Format exceptions nicely (no more RefCell { value: .. }!)

windelbouwman merged commit 978e7ea into RustPython:master

coolreader18 deleted the formatted-exceptions branch

December 27, 2018 15:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet