Make `type()` bases arg only take tuples #2342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

coolreader18 merged 4 commits into RustPython:master from carbotaniuman:type

Dec 12, 2020

Contributor

carbotaniuman commented Nov 25, 2020

No description provided.

Member

coolreader18 commented Nov 25, 2020

You can call .borrow_value() on the tuple to get a &[PyObjectRef], and then use that instead of the PyIterable

Member

coolreader18 commented Nov 25, 2020

Oh I see, cause it has to be Vec<PyTypeRef>. Maybe just .borrow_value().iter().map(typeref tryfromobject).collect::<PyResult<Vec<PyTypeRef>>()?

Member

coolreader18 commented Dec 6, 2020

I recently added a builtins::tuple::PyTupleTyped type, you could try making the type of bases: PyTupleTyped<PyTypeRef>

carbotaniuman added 2 commits

December 10, 2020 22:16


          Make type() bases arg only take tuples

0f2bd59


          Update

a6afbdf

carbotaniuman force-pushed the type branch from ef277f9 to a6afbdf Compare

December 11, 2020 04:30

Contributor Author

carbotaniuman commented Dec 11, 2020

Updated. Is there a reason you added the Transmute... trait instead of just TryFromObject?

Member

coolreader18 commented Dec 11, 2020

TryFromObject is implemented for a ton of different types and doesn't have any invariants regarding representation, e.g. if it just required TryFromObject you could have PyTupleTyped<u8>, and that obviously wouldn't be safe to cast PyObjectRef to u8. TransmuteFromObject is an unsafe trait, so if anyone wants to implement it wrong they have to use unsafe to do so 🙃

carbotaniuman added 2 commits

December 11, 2020 20:55


          Fix clippy


          Formaat

6cb89fb

coolreader18 approved these changes

View reviewed changes

Member

coolreader18 left a comment

Thanks for contributing!

coolreader18 merged commit 7681892 into RustPython:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet