Lib/test/test_copy.py from CPython v3.8.1 #1633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

youknowone merged 2 commits into RustPython:master from youknowone:test-copy

Jan 31, 2020

Member

youknowone commented Dec 15, 2019

No description provided.

Contributor

palaviv commented Dec 21, 2019

@youknowone I have a put the test_bool.py unittests from CPython in Lib/test. I am working on running them in the CI. The plan on how to add them is specified in #1596.

youknowone force-pushed the test-copy branch from 71f567e to 4705801 Compare

January 30, 2020 17:45

youknowone marked this pull request as ready for review

January 30, 2020 17:45

youknowone changed the title ~~test copy~~ Lib/test/test_copy.py from CPython v3.8.1

palaviv approved these changes

View reviewed changes

Contributor

palaviv left a comment

Looks good. Again if you can mark tests with skip instead of comment out I think it is better.

Member Author

youknowone commented Jan 31, 2020

commented out tests make crash instead of rust error


          Add test_copy.py from CPython v3.8.1

cebca9e

youknowone force-pushed the test-copy branch 2 times, most recently from d982378 to 4ea8a61 Compare

January 31, 2020 08:56

Contributor

palaviv commented Jan 31, 2020

Are they failing when compiling or when you run the test? If that is when you run the test I would prefer adding @unittest.skip("TODO: RUSTPYTHON") as it would be shown clearly when running the tests.


          mark failing tests from test_copy.py

c8e5040

youknowone force-pushed the test-copy branch from 4ea8a61 to c8e5040 Compare

January 31, 2020 09:12

youknowone merged commit 696d2de into RustPython:master

youknowone deleted the test-copy branch

January 31, 2020 12:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet