Set docstring of function as None if not declared #1580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

palaviv merged 1 commit into RustPython:master from seeeturtle:doc-f

Nov 2, 2019

Contributor

seeeturtle commented Nov 2, 2019

In cpython, if there is no docstring declared in function definition,
the __doc__ attribute of the function is None.
So this implements the behavior.


          Set docstring of function as None if not declared

In cpython, if there is no docstring declared in function definition,
the `__doc__` attribute of the function is None.
So this implements the behavior.

Fix RustPython#1523

Contributor

palaviv commented Nov 2, 2019

Great work @seeeturtle. This make the change in #1550 redundant so I would suggest removing it in a different PR.

palaviv merged commit 72989cd into RustPython:master

This was referenced Nov 2, 2019

Update _socket to use the socket2 crate; similar to the C sockets api #1572

Merged

Return function attributes in method #1582

Merged

Contributor Author

seeeturtle commented Nov 3, 2019

@palaviv what do you mean to remove in different PR?

Member

coolreader18 commented Nov 3, 2019

I think he's made the change in #1582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet