Silence three tests following PR #1413 #1422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinushey
approved these changes
Dec 12, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR silences informational messages emitted by three deprecated helper functions (RcppLdPath, RcppLdFlags, LdFlags) during test execution. These functions have been obsolete since 2013 and now emit messages following PR #1413, but the tests still verify they return the correct empty values.
- Wraps three test function calls with
suppressMessages()to prevent output noise - Updates copyright year in the test file from 2019 to 2025
- Documents the changes in the ChangeLog
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| inst/tinytest/test_system.R | Adds suppressMessages() around three obsolete linker/compiler flag function calls and updates copyright year |
| ChangeLog | Documents the test silencing changes with proper date and description |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor 'quality of life' improvement to silence three tests that assert that the (old, unused) helpers for compiler and linker flags do the Right Thing (TM) and return nothing, but following #1413 emit a message. Which we now suppress.
When these get deprecated / warn we will change the tests or possibly add tests for warnings.
Checklist
R CMD checkstill passes all tests