Add MariaDB mention in repo description and improve example with exception handling (#1180) #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

theneuralcraftsman wants to merge 1 commit into PyMySQL:main from theneuralcraftsman:main

Contributor

theneuralcraftsman commented Sep 16, 2024

This PR addresses issue #1180, which requested adding MariaDB to the repository description, similar to how it was done for PyMySQL/mysqlclient in PyMySQL/mysqlclient#719.

Additionally, I updated the example code by incorporating try, except, and finally blocks to ensure proper error handling and cleanup when interacting with the database. This improves the robustness of the code and ensures that the connection is always closed, even in case of an error.

Changes made:

Added MariaDB to the repo description.
Updated the example with error handling and resource management using try, except, and finally.

Let me know if further changes are needed.


          Update README.md

dac84ec

Member

methane commented Sep 18, 2024

It reduces the robustness.

remove traceback from the error.
with statement ensures that connections closed always already.

You should avoid try statement as possible to write robust code.
Read the "A Philosophy of Software Design, 2nd Edition".

methane closed this

Contributor Author

theneuralcraftsman commented Sep 18, 2024 •

edited

Loading

Thanks for the feedback and the book recommendation! I've reverted the try-except changes and updated the repository description to include MariaDB as requested. Please check PR(#1186).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet