Skip to content

Conversation

@cfbolz
Copy link
Contributor

@cfbolz cfbolz commented Sep 3, 2024

this should fix #1183.

@codecov
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.75%. Comparing base (1e28be8) to head (7492e28).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1184      +/-   ##
==========================================
+ Coverage   86.24%   86.75%   +0.50%     
==========================================
  Files          17       17              
  Lines        2436     2423      -13     
  Branches      258      257       -1     
==========================================
+ Hits         2101     2102       +1     
+ Misses        249      238      -11     
+ Partials       86       83       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cfbolz
Copy link
Contributor Author

cfbolz commented Sep 4, 2024

@methane thanks for enabling the CI runs and fixing the spacing!

The complaint of coverage is that it seems the catch-all except BaseException in Connection.connect isn't being hit by any test, right?

I'll try to add a test for that. Also, the code in that except is basically _force_close now, maybe we should simply call that there.

@methane methane merged commit 9204b64 into PyMySQL:main Sep 5, 2024
@methane
Copy link
Member

methane commented Sep 5, 2024

thanks

Yevhenii-Yatchenko pushed a commit to Yevhenii-Yatchenko/PyMySQL that referenced this pull request Sep 20, 2024
poadoc pushed a commit to poadoc/PyMySQL that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Connection._force_close relies on garbage collector to close SocketIO instances

2 participants