AssemblyAI - New Transcription Completed - Bug Fix #17811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

michelle0927 wants to merge 2 commits into master from issue-17808

+21 −16

Collaborator

michelle0927 commented Jul 25, 2025 •

edited by coderabbitai bot

Loading

Resolves #17808

Summary by CodeRabbit

New Features
- Improved transcript pagination with support for early termination based on a specific transcript ID.
Chores
- Updated version numbers for several components and actions.
- Upgraded a package dependency for improved compatibility.

michelle0927 added 2 commits

July 25, 2025 12:55


          update pagination

a8c9838


          pnpm-lock.yaml

c9acf34

vercel bot commented Jul 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	⬜️ Ignored (Inspect)			Jul 25, 2025 4:58pm
pipedream-docs	⬜️ Ignored (Inspect)			Jul 25, 2025 4:58pm
pipedream-docs-redirect-do-not-edit	⬜️ Ignored (Inspect)			Jul 25, 2025 4:58pm

Contributor

coderabbitai bot commented Jul 25, 2025 •

edited

Loading

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

components/assemblyai/actions/create-captions/create-captions.mjs

Oops! Something went wrong! :(

ESLint: 8.57.1

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
at Object.getPackageJSONURL (node:internal/modules/package_json_reader:255:9)
at packageResolve (node:internal/modules/esm/resolve:767:81)
at moduleResolve (node:internal/modules/esm/resolve:853:18)
at defaultResolve (node:internal/modules/esm/resolve:983:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:801:12)
at #cachedDefaultResolve (node:internal/modules/esm/loader:725:25)
at ModuleLoader.resolve (node:internal/modules/esm/loader:708:38)
at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:309:38)
at #link (node:internal/modules/esm/module_job:202:49)

components/assemblyai/assemblyai.app.mjs

Oops! Something went wrong! :(

ESLint: 8.57.1

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
at Object.getPackageJSONURL (node:internal/modules/package_json_reader:255:9)
at packageResolve (node:internal/modules/esm/resolve:767:81)
at moduleResolve (node:internal/modules/esm/resolve:853:18)
at defaultResolve (node:internal/modules/esm/resolve:983:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:801:12)
at #cachedDefaultResolve (node:internal/modules/esm/loader:725:25)
at ModuleLoader.resolve (node:internal/modules/esm/loader:708:38)
at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:309:38)
at #link (node:internal/modules/esm/module_job:202:49)

components/assemblyai/sources/new-transcription-completed/new-transcription-completed.mjs

Oops! Something went wrong! :(

ESLint: 8.57.1

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
at Object.getPackageJSONURL (node:internal/modules/package_json_reader:255:9)
at packageResolve (node:internal/modules/esm/resolve:767:81)
at moduleResolve (node:internal/modules/esm/resolve:853:18)
at defaultResolve (node:internal/modules/esm/resolve:983:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:801:12)
at #cachedDefaultResolve (node:internal/modules/esm/loader:725:25)
at ModuleLoader.resolve (node:internal/modules/esm/loader:708:38)
at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:309:38)
at #link (node:internal/modules/esm/module_job:202:49)

1 others

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0471e62 and c9acf34.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (5)

components/assemblyai/actions/create-captions/create-captions.mjs (1 hunks)
components/assemblyai/actions/get-transcription/get-transcription.mjs (1 hunks)
components/assemblyai/assemblyai.app.mjs (1 hunks)
components/assemblyai/package.json (2 hunks)
components/assemblyai/sources/new-transcription-completed/new-transcription-completed.mjs (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

components/assemblyai/assemblyai.app.mjs (1)

components/assemblyai/sources/new-transcription-completed/new-transcription-completed.mjs (1)

transcripts (57-62)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

GitHub Check: Verify TypeScript components
GitHub Check: Publish TypeScript components
GitHub Check: pnpm publish
GitHub Check: Lint Code Base

🔇 Additional comments (8)

components/assemblyai/sources/new-transcription-completed/new-transcription-completed.mjs (1)

8-8: Version bump aligns with the underlying bug fix.

The version increment from "0.0.1" to "0.0.2" is appropriate as it reflects the bug fix in the underlying paginateTranscripts method that this source component relies on.

components/assemblyai/actions/create-captions/create-captions.mjs (1)

7-7: Version bump maintains consistency across the component suite.

The version increment from "0.0.1" to "0.0.2" is appropriate as part of a coordinated release across all AssemblyAI components, ensuring version consistency even though this specific component doesn't directly utilize the bug fix.

components/assemblyai/actions/get-transcription/get-transcription.mjs (1)

7-7: Version bump maintains consistency across the component suite.

The version increment from "0.0.3" to "0.0.4" is appropriate as part of a coordinated release across all AssemblyAI components, ensuring version consistency.

components/assemblyai/package.json (2)

3-3: Package version bump is consistent with component updates.

The version increment from 0.2.1 to 0.2.2 appropriately reflects the bug fix and coordinated component updates.

16-16: Verify assemblyai component compatibility with @pipedream/platform v3.1.0

Since the PR bumps @pipedream/platform from ^1.x to ^3.1.0, please ensure the AssemblyAI component still works as expected:

• In components/assemblyai/assemblyai.app.mjs
– Confirm import { axios } from "@pipedream/platform" still resolves and that any Axios-based calls use the correct signature.
• In components/assemblyai/sources/new-transcription-completed/new-transcription-completed.mjs
– Verify DEFAULT_POLLING_SOURCE_TIMER_INTERVAL is still exported and returns the intended value.
• Run the existing test suite and smoke-test the component in isolation to catch any breaking changes in platform APIs (e.g., renamed exports, config transforms, renamed helpers).

components/assemblyai/assemblyai.app.mjs (3)

102-102: Good implementation of the after_id parameter extraction.

Extracting the after_id parameter before the pagination loop allows for clean early termination logic.

108-113: Excellent bug fix for pagination early termination.

The implementation correctly addresses the core issue by:

Iterating through each transcript in the current page

Checking if the transcript ID matches the after_id parameter

Returning immediately when the target transcript is found, preventing unnecessary API calls

Adding new transcripts to results only if they haven't reached the termination condition

This fix resolves the inefficient pagination behavior referenced in the PR title.

114-114: Smart parameter cleanup prevents API request interference.

Clearing the after_id parameter after processing each page ensures that subsequent API requests in the pagination loop aren't affected by the original filtering parameter, which is correct since the early termination logic handles the filtering at the application level.

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch issue-17808

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

pipedream-component-development requested a review from jcortes

July 25, 2025 17:14

jcortes approved these changes

View reviewed changes

Collaborator

jcortes left a comment

Hi @michelle0927 lgtm! Ready for QA!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet