🚀 [Breaking pre-release]: Remove AppID from GitHubApp
#523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request removes the AppID property from the GitHubApp class to simplify the class structure and ensure consistency in object construction. The change eliminates redundant functionality since the ID property already serves the same purpose as the AppID property.
- Removed the
AppIDproperty declaration and its initialization in theGitHubAppconstructor - Updated
GitHubAppInstallationconstructors to no longer pass theapp_idparameter when creatingGitHubAppobjects
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/classes/public/App/GitHubApp.ps1 | Removed AppID property declaration and assignment in constructor |
| src/classes/public/App/GitHubAppInstallation.ps1 | Removed app_id parameter from GitHubApp object creation in both constructors |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
AppID from GitHubAppAppID from GitHubApp
Contributor
|
Module GitHub - 0.39.0 published to the PowerShell Gallery. |
Contributor
|
GitHub release for GitHub v0.39.0 has been created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request removes the
AppIDproperty from theGitHubAppclass and eliminates its usage throughout the codebase. The changes help simplify the class structure and ensure consistency in object construction.Class structure simplification:
AppIDproperty from theGitHubAppclass definition insrc/classes/public/App/GitHubApp.ps1.AppIDin theGitHubAppconstructor insrc/classes/public/App/GitHubApp.ps1.Object construction consistency:
app_idproperty when creatingGitHubAppobjects in both constructors of theGitHubAppInstallationclass insrc/classes/public/App/GitHubAppInstallation.ps1. [1] [2]Type of change
Checklist