Skip to content

Fix multi-rank debug case problem #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

sbryngelson
Copy link
Member

Fix debug a problem with multi-rank. t_step_start was not broadcast leading to a deadlock.

This was introduced when we added additional debug flags.

Only occurred with multi rank debug cases.

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.99%. Comparing base (6fe815d) to head (2c3e88e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #696   +/-   ##
=======================================
  Coverage   42.99%   42.99%           
=======================================
  Files          61       61           
  Lines       16053    16053           
  Branches     1796     1796           
=======================================
  Hits         6902     6902           
  Misses       8167     8167           
  Partials      984      984           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbryngelson sbryngelson merged commit 6bad379 into MFlowCode:master Nov 6, 2024
23 checks passed
@sbryngelson sbryngelson deleted the fix_debug_hang branch November 6, 2024 19:56
max-Hawkins pushed a commit to max-Hawkins/MFC that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant