read nexus tree blocks: with translate tables and networks #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@crsl4 : could you please review? This PR is modifying a function that you originally wrote, and that you may be using more often than folks in my group. Also, you may be aware of network-formatting in BEAST2 that I'm not aware of. |
Codecov Report
@@ Coverage Diff @@
## master #197 +/- ##
==========================================
+ Coverage 86.59% 86.65% +0.05%
==========================================
Files 30 30
Lines 12553 12630 +77
==========================================
+ Hits 10870 10944 +74
- Misses 1683 1686 +3
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
crsl4
approved these changes
Apr 7, 2023
Member
crsl4
left a comment
There was a problem hiding this comment.
I don't use this function much. New function looks good (and better!). Thanks Cecile!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readNexusTreeschanged toreadnexus_treeblockassumptions about network format: based on BEAST2 output.