feat(genai): Add Live API samples #13521
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @Guiners, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly expands the genai live samples by introducing several new Python examples. These samples showcase diverse real-time interactions with the Generative AI models, covering audio, text, and tool-use functionalities. The changes also include minor formatting adjustments to existing websocket-based samples and updates to the test suite to validate the new additions.
Highlights
- New
genaiLive Samples: Added six new Python samples demonstrating various 'live' capabilities of thegoogle.genaiSDK. These include generating audio from text, performing live code execution, handling live function calls, grounding responses with Google Search, transcribing audio, and generating text from audio input. - Test Coverage Expansion: Updated the
test_live_examples.pyfile to include asynchronous tests for each of the newly addedgenailive samples, ensuring their functionality and correctness. - Code Formatting Improvements: Applied minor formatting adjustments (e.g., line breaks for better readability) to several existing websocket-based
genailive samples.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request adds several new samples for the GenAI "live" feature and refactors some existing ones. The new samples cover a wide range of functionalities, including audio generation, code execution, function calling, and transcription.
Overall, the additions are valuable, but there are several critical issues in the new sample files that will cause them to fail at runtime. These include incorrect API usage, missing imports, and logic errors that can lead to UnboundLocalError. Additionally, some samples have issues that affect their usability and adherence to asynchronous programming best practices.
I've provided detailed comments on these issues with suggestions for how to fix them. Addressing these points will significantly improve the quality and reliability of the new samples.
| audio_bytes = get_audio(audio_url) | ||
|
|
||
| # If you've pre-converted to sample.pcm using ffmpeg, use this instead: | ||
| # audio_bytes = Path("sample.pcm").read_bytes() |
There was a problem hiding this comment.
Where does this Path method comes from ? Can you share more details
# audio_bytes = Path("sample.pcm").read_bytes()
There was a problem hiding this comment.
It was hardcoded in the example, I can remove that @msampathkumar
|
Here is the summary of changes. You are about to add 7 region tags.
This comment is generated by snippet-bot.
|
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)