Correct README.md #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The removed lines below are actually allowed in typescript. // ❌ This is not allowed due to type safety // const selectedType2: MediaTypes = MediaTypes.Video; // ❌ This is not allowed due to type safety // const invalidType: MediaTypes = 'image';
README.md
Outdated
| // ✅ Accessing the value | ||
| const associatedText: string = MediaTypes.Image; | ||
|
|
||
| // ❌ This is not allowed due to type safety | ||
| // const invalidType: MediaTypes = 'image'; |
There was a problem hiding this comment.
This statement is not allowed because Assigning a string like 'image' to a variable of an enum type (MediaTypes) is a type error in TypeScript
There was a problem hiding this comment.
Yes, thank you for correcting me :)
| @@ -314,14 +314,9 @@ enum MediaTypes { | |||
|
|
|||
| const selectedType: MediaTypes = MediaTypes.Image; | |||
|
|
|||
| // ❌ This is not allowed due to type safety | |||
| // const selectedType2: MediaTypes = MediaTypes.Video; | |||
Done! |
|
Kindly merge it if it looks good now @Devinterview-io |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removed lines below are actually allowed in typescript.