Skip to content

feat: Added Yoruba translations and updated French #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DenverCoder1 merged 8 commits into from
Jan 5, 2023
Merged

feat: Added Yoruba translations and updated French #407

DenverCoder1 merged 8 commits into from
Jan 5, 2023

Conversation

@Halim-Shams
Copy link
Contributor

@Halim-Shams Halim-Shams commented Jan 5, 2023 •
edited by DenverCoder1
Loading

Description

Ref: #236

Type of change

  • New feature (added a non-breaking change which adds functionality)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Halim-Shams and others added 6 commits December 28, 2022 17:32
@Halim-Shams
Added Pashto translations
4590461 
## Description
Fixes DenverCoder1#236

### Type of change
- [x] New feature (added a non-breaking change which adds functionality)

## How Has This Been Tested?
- [x] Tested locally with a valid username
- [x] Tested locally with an invalid username
- [x] Ran tests with composer test
- [x] Added or updated test cases to test new features

## Checklist:
- [x] I have checked to make sure no other pull requests are open for this issue
- [x] The code is properly formatted and is consistent with the existing code style
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
@Halim-Shams
Merge pull request #1 from Halim-Shams/added-pashto
84c9664 
Added Pashto translations
@collinsoden
Added translation for Yoruba
08283e1
@Halim-Shams
Merge branch 'DenverCoder1:main' into main
9942570
@Halim-Shams
Merge pull request #2 from Collinsoden22/patch-1
b9727a2 
Added translation for Yoruba
@Halim-Shams
changed the language shortcut from 'yor' to 'yo'
4c84c2b
@Halim-Shams Halim-Shams mentioned this pull request Jan 5, 2023
Open
DenverCoder1
DenverCoder1 approved these changes Jan 5, 2023
View reviewed changes
Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

@DenverCoder1 DenverCoder1 changed the title Added Yoruba translations feat: Added Yoruba translations and updated French Jan 5, 2023
@DenverCoder1 DenverCoder1 merged commit 4077d6e into DenverCoder1:main Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DenverCoder1 DenverCoder1 DenverCoder1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Halim-Shams @DenverCoder1 @collinsoden