feat(loadtestservice): Added runName feature #51425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new RunName feature to the Playwright service, allowing users to specify a custom run name that defaults to the RunId if not provided. The implementation includes validation logic that truncates run names exceeding 200 characters and provides comprehensive test coverage for various scenarios.
Key changes:
- Added
RunNameproperty toPlaywrightServiceBrowserClientOptionswith length validation and truncation - Implemented
GetDefaultRunName()method inClientUtilitiesto handle default values - Added environment variable support for run names
- Enhanced constructor to initialize the new run name functionality
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| PlaywrightServiceBrowserClientTests.cs | Added comprehensive test coverage for RunName functionality including default behavior, custom values, truncation, and environment variable handling |
| ClientUtilities.cs | Added GetDefaultRunName() method to provide default run name logic |
| PlaywrightServiceBrowserClientOptions.cs | Implemented RunName property with validation, truncation logic, and environment variable integration |
| PlaywrightServiceBrowserClient.cs | Updated constructor to initialize RunName property |
| Constants.cs | Added environment variable constant for run name |
sdk/loadtestservice/Azure.Developer.Playwright/src/PlaywrightServiceBrowserClientOptions.cs
Outdated
Show resolved
Hide resolved
sdk/loadtestservice/Azure.Developer.Playwright/src/PlaywrightServiceBrowserClientOptions.cs
Show resolved
Hide resolved
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
puagarwa
reviewed
Jul 24, 2025
sdk/loadtestservice/Azure.Developer.Playwright/src/PlaywrightServiceBrowserClientOptions.cs
Outdated
Show resolved
Hide resolved
sdk/loadtestservice/Azure.Developer.Playwright/src/PlaywrightServiceBrowserClientOptions.cs
Outdated
Show resolved
Hide resolved
sdk/loadtestservice/Azure.Developer.Playwright/src/Utility/ClientUtilities.cs
Outdated
Show resolved
Hide resolved
puagarwa
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.