Fix null pointer dereference in check_sync_fuzzers #2506
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe
This patch fixes a potential null pointer dereference in the
check_sync_fuzzers()function by moving theclosedir(dir)call inside theif (dir)block.Expected Behavior
closedir(dir)should only be called whendiris a valid directory pointer returned byopendir().This ensures the program avoids undefined behavior when
opendir()fails.Actual Behavior
Previously,
closedir(dir)was called unconditionally, even whendirmight beNULLdue toopendir()failure.Calling
closedir(NULL)results in undefined behavior and may cause a segmentation fault.This change prevents undefined behavior and improves stability in edge cases.
Thanks for reviewing.