Skip to content

[Mailer] Mailtrap sandbox #61305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

KiloSierraCharlie
Copy link

@KiloSierraCharlie KiloSierraCharlie commented Aug 2, 2025

Q A
Branch? 7.4
Bug fix? yes
New feature? no
Deprecations? no
Issues N/A
License MIT

The Mailtrap API requires the inbox ID to be passed as part of the URI when using sandbox mode, however the original package neglected to pass this. This PR enabes the inbox ID to be passed to the API as part of the URI when provided through MAILER_DSN in the environment variables.

Submitted as bug as opposed to new feature as the use of sandbox mode is advertised on the mailtrap dashboard when configuring services, and so backwards compatability with the package would be ideal.

nicolas-grekas and others added 30 commits June 2, 2025 16:17
This PR was merged into the 7.4 branch.

Discussion
----------

Allow Symfony ^8.0

| Q             | A
| ------------- | ---
| Branch?       | 7.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Commits
-------

a2eeadc Allow Symfony ^8.0
This PR was merged into the 7.4 branch.

Discussion
----------

also test patched components with 6.4

| Q             | A
| ------------- | ---
| Branch?       | 7.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

Commits
-------

9e0413f also test patched components with 6.4
* 7.3:
  [VarDumper] Fix tests on PHP 8.4
  [Yaml] fix support for years outside of the 32b range on x86 arch on PHP 8.4
  use STARTTLS for SMTP with MailerSend
This PR was merged into the 7.4 branch.

Discussion
----------

fix low deps build

| Q             | A
| ------------- | ---
| Branch?       | 7.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

Commits
-------

591f893 fix low deps build
* 7.3:
  [JsonStreamer] lazyGhostsDir should be optional
  [TypeInfo] Fix type alias resolving
  [Validator] review cs tran
  Fix building packages in the CI
  implicitly run all Composer commands non-interactively
  re-add accidentally removed changelog examples
  [TypeInfo] Handle `key-of` and `value-of` types
  [PhpUnitBridge] Skip bootstrap for PHPUnit >=10
  [FrameworkBundle] ensureKernelShutdown in tearDownAfterClass
  don't register SchedulerTriggerNormalizer without symfony/serializer
  [TypeInfo] Fix merging collection value types with union types
This PR was merged into the 7.4 branch.

Discussion
----------

Improve typing for process callback

| Q             | A
| ------------- | ---
| Branch?       | 7.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

I always find myself digging into the source code to determine what the "shape" of the callback should be. This improvement allows static analysis tools to ensure its correct now.

Commits
-------

d8dc857 [Process] Improve typing for process callback
…cks (nicolas-grekas)

This PR was merged into the 7.4 branch.

Discussion
----------

Tweak return type declarations and related CI checks

| Q             | A
| ------------- | ---
| Branch?       | 7.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Commits
-------

ad7c6b9 Tweak return type declarations and related CI checks
…< 5 (nicolas-grekas)

This PR was merged into the 7.4 branch.

Discussion
----------

[HttpClient] Deprecate using amphp/http-client < 5

| Q             | A
| ------------- | ---
| Branch?       | 7.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Commits
-------

052bc4f [HttpClient] Deprecate using amphp/http-client < 5
* 7.3:
  [HttpClient] Suggest amphp/http-client v5 by default
  [WebProfilerBundle] Fix typos in routing config deprecation messages
  cs tweak
  [FrameworkBundle] ensureKernelShutdown in tearDownAfterClass
  Revert "bug symfony#60564 [FrameworkBundle] ensureKernelShutdown in tearDownAfterClass (cquintana92)"
  [Security] Keep roles when serializing tokens
  [JsonPath] Always use brackets notation with `JsonPath::key()`
…olas-grekas)

This PR was merged into the 7.4 branch.

Discussion
----------

[Security] conflict with event-subscriber v8

| Q             | A
| ------------- | ---
| Branch?       | 7.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

`Http\Firewall` doesn't have return types in v7.4 to make upgrades smoother, but this also means that this class is not compatible with `EventSubscriberInterface` v8 since we added return types there.

Commits
-------

542cc71 [Security] conflict with event-subscriber v8
…rlGenerator` using `_query` (BenMorel)

This PR was merged into the 7.4 branch.

Discussion
----------

[Routing] Allow query-specific parameters in `UrlGenerator` using `_query`

| Q             | A
| ------------- | ---
| Branch?       | 7.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Issues        | -
| License       | MIT

This PR adds support for a special `_query` key in `$parameters` of `UrlGenerator::generate()`, that is used exclusively to generate query parameters. This is useful when query parameters may conflict with route parameters of the same name.

Concrete use case:

My application has a route that looks like:

    https://{siteCode}.{domain}/admin/stats

And I want to generate this URL:

    https://fr.example.com/admin/stats?siteCode=us

With this PR, I can now call:

```php
$urlGenerator->generate('admin_stats', [
    'siteCode' => 'fr',
    'domain' => 'example.com',
    '_query' => [
        'siteCode' => 'us',
    ]
]);
```

Commits
-------

e3513bd Allow query-specific parameters in URL generator using `_query`
…` (jprivet-dev)

This PR was squashed before being merged into the 7.4 branch.

Discussion
----------

[PhpUnitBridge] Add `strtotime()` to `ClockMock`

| Q             | A
| ------------- | ---
| Branch?       | 7.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Issues        |
| License       | MIT

Commits
-------

fc9491e [PhpUnitBridge] Add `strtotime()` to `ClockMock`
* 7.3:
  Test AssetMapper with and without ext-brotli/ext-zstd in one job
  [JsonPath] Fix typo in comment in JsonCrawler
* 7.3:
  [DependencyInjection] Fix `ServiceLocatorTagPass` indexes handling
  Improve docblock on compile()
  [JsonPath] Better handling of Unicode chars in expressions
  [VarDumper] Fix dumping LazyObjectState when using VarExporter v8
  Allow NumberToLocalizedStringTransformer empty values
  [Intl] Ensure data consistency between alpha and numeric codes
  [Intl] Add missing currency (NOK) localization (en_NO)
…on symfony/event-dispatcher (xabbuh)

This PR was merged into the 7.4 branch.

Discussion
----------

[Security] remove no longer needed conflict rule on symfony/event-dispatcher

| Q             | A
| ------------- | ---
| Branch?       | 7.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

Commits
-------

aa94da2 remove no longer needed conflict rule on symfony/event-dispatcher
…mmand name passed to the constructor (HypeMC)

This PR was merged into the 7.4 branch.

Discussion
----------

[Console] Allow setting aliases & hidden via command name passed to the constructor

| Q             | A
| ------------- | ---
| Branch?       | 7.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Issues        | Fix symfony#60394 (comment)
| License       | MIT

Currently, setting an alias and/or marking a command as hidden via the name doesn't work when the name is passed as a constructor argument. For example:

```php
$command = new MyCommand('name|alias');
```

This issue was noticed while working on symfony#60394 as mentioned in the comment there: symfony#60394 (comment).

Commits
-------

03d612a [Console] Fix setting aliases & hidden via name
…arld)

This PR was merged into the 7.4 branch.

Discussion
----------

[JsonStreamer] Add PHPDoc to generated code

| Q             | A
| ------------- | ---
| Branch?       | 7.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

In order to ease debugging of generated code, it is useful to know which type is related to a given generated PHP file.
That's why this PR add some PHPDoc in order know which type is handled.

Commits
-------

78be7eb [JsonStreamer] Add PHPDoc to generated code
nicolas-grekas and others added 3 commits August 1, 2025 18:16
This PR was merged into the 7.4 branch.

Discussion
----------

run tests using PHPUnit 11.5

| Q             | A
| ------------- | ---
| Branch?       | 7.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

Commits
-------

652ba2e run tests using PHPUnit 11.5
* 7.3:
  account for error message changes in PHP 8.5
  [Form] Fix interface name in Guess documentation
  Bump Symfony version to 7.3.3
  Update VERSION for 7.3.2
  Update CHANGELOG for 7.3.2
  Bump Symfony version to 6.4.25
  Update VERSION for 6.4.24
  Update CONTRIBUTORS for 6.4.24
  Update CHANGELOG for 6.4.24
  [DependencyInjection] Escape parameters before resolving env placeholders
  [Validator] review Persian translation for Twig template
* 7.3:
  account for error message changes in PHP 8.5
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.4" but it seems your PR description refers to branch "7.2".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@KiloSierraCharlie KiloSierraCharlie changed the base branch from 7.4 to 7.2 August 2, 2025 15:13
@OskarStark
Copy link
Contributor

Please target 6.4 or 7.3 as 7.2 is no longer maintained, thanks

@KiloSierraCharlie KiloSierraCharlie changed the base branch from 7.2 to 7.3 August 2, 2025 16:42
@KiloSierraCharlie
Copy link
Author

Apologies, changed to 7.3.

@fabpot
Copy link
Member

fabpot commented Aug 2, 2025

As you're adding a new method, this is considered as a new feature, so it should target 7.4. Sorry about that.

…g ContainerBuilders (MatTheCat)

This PR was merged into the 7.4 branch.

Discussion
----------

[FrameworkBundle] Escape parameters when serializing ContainerBuilders

| Q             | A
| ------------- | ---
| Branch?       | 7.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | N/A
| License       | MIT

Since the `XmlDumper` didn’t escape uncompiled containers’ parameters, there was no way to differentiate a parameter placeholder from its escaped counterpart (e.g. `%%foo%%` and `%foo%` both are dumped as `%foo%`). This could make `lint:container --resolve-env-vars` fail in some cases.

This PR doesn’t change the `XmlDumper` to keep BC, but alter the way `ContainerBuilder`s are serialized by symfony#60597 as it didn’t get released yet.

Commits
-------

8ad916f [FrameworkBundle] Escape parameters when serializing a ContainerBuilder
@KiloSierraCharlie
Copy link
Author

I've messed up somewhere.... I'll re-submit the PR with 7.4 as base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.