Skip to content

Adjust database. #16739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ssinnott merged 1 commit into from
Dec 12, 2025
Merged

Adjust database. #16739

ssinnott merged 1 commit into from
Dec 12, 2025
+2 −2

Conversation

@ssinnott
Copy link
Contributor

@ssinnott ssinnott commented Dec 12, 2025

Intent

So this was adjusted in the gtest PR (#16389). I think it must have come in from a git operation because of how specific they are. There's a change lower in the file that I did add specifically add.

Approach

Rolls it back to the original version.

Automated Tests

Tests should run.

QA Notes

Ensure you have updated the QA Notes in the original issue.

Documentation

Specify which documentation has been added or modified and why (User Guide? Admin Guide?). If no documentation was added for a new feature, indicate why. If documentation was added in a separate PR, link the PR here.

Checklist

  • If this PR adds a new feature, or fixes a bug in a previously released version, it includes an entry in NEWS.md
  • If this PR adds or changes UI, the updated UI meets accessibility standards
  • A reviewer is assigned to this PR (if unsure who to assign, check Area Owners list)
  • This PR passes all local unit tests

@ssinnott ssinnott requested a review from jeffvroom December 12, 2025 01:31
@posit-snyk-bot
Copy link
Contributor

posit-snyk-bot commented Dec 12, 2025 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

jeffvroom
jeffvroom approved these changes Dec 12, 2025
View reviewed changes
Copy link
Contributor

@jeffvroom jeffvroom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ssinnott ssinnott merged commit 8b1aa3a into main Dec 12, 2025
13 checks passed
@ssinnott ssinnott deleted the revert-random-database-change branch December 12, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffvroom jeffvroom jeffvroom approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ssinnott @posit-snyk-bot @jeffvroom