Support standard tickdir control (in/out/inout) in axisartist. #30369
+149
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a80878e to
6831cb5
Compare
timhoffm
reviewed
Jul 30, 2025
|
Sure, done. |
timhoffm
reviewed
Jul 30, 2025
|
No worries, it's good to improve this... |
timhoffm
approved these changes
Jul 31, 2025
|
Some refs still need fixing: |
timhoffm
reviewed
Jul 31, 2025
timhoffm
reviewed
Jul 31, 2025
... and also respect rcParams, which makes axisartist ticks default to
pointing outwards, similarly to standard ticks.
Rework the tick direction machinery to also support "inout" (similarly
to standard ticks).
One may wonder whether external ticks should really be drawn in the
local direction of the gridlines, though, or whether drawing them
orthogonal to the axis spine would look better. This PR keeps the old
behavior of `set_ticks_out(True)`, but we could later add something like
``set_tick_direction("out_ortho")`` (name up to bikeshedding).
While at it, also deprecate the entirely unused
`Ticks.locs_angles_labels` and `LabelBase.locs_angles_labels`.
|
Hopefully the missing references are fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and also respect rcParams, which makes axisartist ticks default to pointing outwards, similarly to standard ticks.
Rework the tick direction machinery to also support "inout" (similarly to standard ticks).
One may wonder whether external ticks should really be drawn in the local direction of the gridlines, though, or whether drawing them orthogonal to the axis spine would look better. This PR keeps the old behavior of
set_ticks_out(True), but we could later add something likeset_tick_direction("out_ortho")(name up to bikeshedding).While at it, also deprecate the entirely unused
Ticks.locs_angles_labelsandLabelBase.locs_angles_labels.See the modified simple_axis_pad example:
and demo_curvelinear grid shows why "out_ortho" may actually be a better option:
PR summary
PR checklist