Revert "fix" #6646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

taylorotwell merged 1 commit into laravel:12.x from RobertBoes:revert-cookie-name

Jul 28, 2025

+1 −1

Contributor

RobertBoes commented Jul 28, 2025 •

edited

Loading

This reverts commit dd473ea.

I don't know what this commit was supposed to fix, because the commit message doesn't mention it and neither do the release notes / changelog. This does however cause issues if you have a dot (.) in your app name. See laravel/framework#56449 and laravel/framework#16167 (comment)

If the app name is set to myapp.com then PHP would convert the dot to an underscore. Inspecting the request it would set the cookie myapp.com_session, but then dumping the cookies on the server ($request->cookies) it would show myapp_com_session with the value being null


          Revert "fix"

eb5eb71

This reverts commit dd473ea.

Contributor Author

RobertBoes commented Jul 28, 2025 •

edited

Loading

Looks like the issue originates from #6636. What's the reason for this change? Things worked perfectly fine, but there are more issues from this, see laravel/framework#56275. There was a previous attempt at fixing the issue (#6644), but this was closed with no clear reason. The issue still persists.

taylorotwell closed this

taylorotwell reopened this

taylorotwell merged commit 902200e into laravel:12.x

9 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet