Update .env.example to fix smilar locales issue #6643
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using short locale codes can become a potential issue in large projects, especially when developers need to support similar languages, such as English (US) and English (UK). While both are English, there are notable differences in spelling, vocabulary, and formatting. Relying on a generic locale like `en` is misleading and can lead to unexpected behavior. For example, the `php artisan lang:publish` command currently generates the `lang/en` directory based on the `APP_LOCALE` value from the `.env` file. However, this approach is flawed. It would be more accurate to generate a directory like `lang/en_US` to avoid conflicts between similar locales and provide proper localization support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using short locale codes can become a potential issue in large projects, especially when developers need to support similar languages, such as English (US) and English (UK). While both are English, there are notable differences in spelling, vocabulary, and formatting. Relying on a generic locale like
enis misleading and can lead to unexpected behavior.For example, the
php artisan lang:publishcommand currently generates thelang/endirectory based on theAPP_LOCALEvalue from the.envfile. However, this approach is flawed. It would be more accurate to generate a directory likelang/en_USto avoid conflicts between similar locales and provide proper localization support.