Improve typing of arrays and callables #56470
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaedrich
commented
Jul 28, 2025
| @@ -39,7 +39,7 @@ public function connect(array $servers, $connectionId = null, array $options = [ | |||
| * Get a new Memcached instance. | |||
| * | |||
| * @param string|null $connectionId | |||
| * @param array $credentials | |||
| * @param array{string, string} $credentials | |||
There was a problem hiding this comment.
Types taken from Memcached::setSaslAuthData()
shaedrich
commented
Jul 28, 2025
shaedrich
commented
Jul 28, 2025
| @@ -287,6 +287,7 @@ protected function createDynamodbDriver(array $config) | |||
| /** | |||
| * Create new DynamoDb Client instance. | |||
| * | |||
| * @param array{region: string, endpoint?: string, key?: string, secret?: string, token?: string} $config | |||
There was a problem hiding this comment.
Types taken from \Aws\DynamoDb\DynamoDbClient
|
@browner12 What do you dislike about this PR? |
|
Can PphStorm recognize these formats? |
|
As far as I'm concerned, they are recognized by PHPStan as well as psalm, which should cover the majority of the ecosystem. I don't have PHPStorm installed to check explicitly, but assuming, it follows common sense, that should work, I'd say. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.