Rust: remove shipped feature flag #2960
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbg
requested changes
Jul 30, 2025
| if ( | ||
| config.languages.includes(Language.rust) && | ||
| !(await codeql.resolveLanguages()).rust | ||
| !(await codeql.resolveLanguages()).rust // means codeql already supports rust without any intervention |
There was a problem hiding this comment.
Minor: I'd prefer this comment to be part of the comment above the if rather than at the end of this line, if you think that it is needed at all.
| @@ -588,32 +587,25 @@ async function run() { | |||
| core.exportVariable(bmnVar, value); | |||
| } | |||
|
|
|||
| // For rust: set CODEQL_ENABLE_EXPERIMENTAL_FEATURES, unless codeql already supports rust without it | |||
| // For rust, if running a version prior to public preview (2.22.1) set CODEQL_ENABLE_EXPERIMENTAL_FEATURES | |||
There was a problem hiding this comment.
I am not sure that this comment accurately describes what is currently implemented. As far as I can tell you check whether the actual CLI version is less than minVer and if so throw a ConfigurationError. That means we never get to the CODEQL_ENABLE_EXPERIMENTAL_FEATURES check.
If that is the case, and that behaviour is unintentional, then you should obviously fix it, but I'd also like to perhaps see this refactored with a test to make sure it does the right thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge / deployment checklist