DEV: Remove now-redundant is_staff guardian check #33852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Drenmi wants to merge 1 commit into main from dev/remove-redundant-staff-check-6

+41 −17

Contributor

Drenmi commented Jul 25, 2025

What is this change?

The edit_all_post_groups used to have TL4 as the default setting. This update:

Adds in admins and moderators as well as makes those mandatory values.
Gets rid of now-redundant is_staff? check.
Makes use of the magic #edit_all_post_groups_map method.

Test coverage is here:

Drenmi requested a review from martin-brennan

July 25, 2025 05:52

martin-brennan approved these changes

View reviewed changes

Drenmi force-pushed the dev/remove-redundant-staff-check-6 branch 2 times, most recently from 487ff78 to cbe2f77 Compare

July 30, 2025 07:53

github-actions bot added the discourse-presence label


          DEV: Remove now-redundant is_staff guardian check

a9eedfe

Drenmi force-pushed the dev/remove-redundant-staff-check-6 branch from cbe2f77 to a9eedfe Compare

July 30, 2025 08:16

github-actions bot added the discourse-calendar label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

discourse-calendar discourse-presence