FIX: default channel name to topic title #33754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We added few weeks ago the possibility to create a channel with the post event, however if the event name was not set we could create an event with no name. This change ensures we will use the topic title in this case, as we do for the event. Channel name max length is using the topic title max length so that shouldn't be a problem.
Grubba27
approved these changes
Jul 22, 2025
CvX
approved these changes
Jul 22, 2025
plugins/discourse-calendar/spec/services/discourse_post_event/chat_channel_sync_spec.rb
Outdated
Show resolved
Hide resolved
…chat_channel_sync_spec.rb Co-authored-by: Jarek Radosz <jradosz@gmail.com>
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/event-chat-channels-error-if-name-clashes/375162/9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added few weeks ago the possibility to create a channel with the post event, however if the event name was not set we could create an event with no name. This change ensures we will use the topic title in this case, as we do for the event.
Channel name max length is using the topic title max length so that shouldn't be a problem.