Skip to content

feat: serve cached digest if available #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 29, 2025
Merged

feat: serve cached digest if available #462

merged 5 commits into from
Jul 29, 2025
+427 −38

Conversation

MickaelCa
Copy link
Member

  • Added methods to upload metadata alongside digest files to S3.
  • Implemented S3-based digest caching mechanism for improved efficiency.
  • Refactored digest storage logic to support both S3 and local storage.

@MickaelCa MickaelCa added push-container Allow the PR to build & push a docker container instead of just building it deploy-pr-temp-env labels Jul 27, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 27, 2025 •
edited
Loading

⚙️ Preview environment was undeployed.

@MickaelCa MickaelCa marked this pull request as ready for review July 27, 2025 16:17
NicolasIRAGNE
NicolasIRAGNE reviewed Jul 27, 2025
View reviewed changes
@MickaelCa MickaelCa force-pushed the use-s3-as-cache branch 2 times, most recently from acb00ea to dd6e541 Compare July 28, 2025 15:05
@MickaelCa MickaelCa requested a review from NicolasIRAGNE July 28, 2025 17:24
NicolasIRAGNE
NicolasIRAGNE approved these changes Jul 28, 2025
View reviewed changes
Copy link
Contributor

@NicolasIRAGNE NicolasIRAGNE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RGPD

ix-56h
ix-56h previously requested changes Jul 28, 2025
View reviewed changes
Copy link
Contributor

@ix-56h ix-56h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we ingest a repo hello_world then try to ingest it again with include/exclude patterns the cache is not used ?

Anyway, LGTM !

MickaelCa added 2 commits July 29, 2025 16:45
@MickaelCa
refactor: simplify query commit resolution
34fe40a 
Combine steps to resolve and assign commit in query_processor.
@MickaelCa
ci: disable fail-fast in matrix strategy
48fc139
NicolasIRAGNE
NicolasIRAGNE approved these changes Jul 29, 2025
View reviewed changes
Copy link
Contributor

@NicolasIRAGNE NicolasIRAGNE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RPDC

@cyclotruc cyclotruc dismissed ix-56h’s stale review July 29, 2025 16:01

fine for now going with simple check 404, can easily switch back if needed

@MickaelCa MickaelCa merged commit efe5a26 into main Jul 29, 2025
25 of 44 checks passed
@MickaelCa MickaelCa deleted the use-s3-as-cache branch July 29, 2025 16:02
@coderamp-ci coderamp-ci bot mentioned this pull request Jul 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasIRAGNE NicolasIRAGNE NicolasIRAGNE approved these changes

@cyclotruc cyclotruc cyclotruc approved these changes

@filipchristiansen filipchristiansen Awaiting requested review from filipchristiansen

@ix-56h ix-56h Awaiting requested review from ix-56h

Assignees
No one assigned
Labels
deploy-pr-temp-env push-container Allow the PR to build & push a docker container instead of just building it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MickaelCa @NicolasIRAGNE @cyclotruc @ix-56h