2. Try: Make battery module update on plugging/unplugging again (refs #2519) #4616
+52
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have a FreeBSD system to test on, but this fixes the issue for me on Linux! Though, there is a delay of about 3 seconds from when the indicator light changes on my 11th gen framework 13 laptop. |
nyiyui
added a commit
to nyiyui/etc-nixos
that referenced
this pull request
Nov 19, 2025
Remove after Alexays/Waybar#4616 is merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the corrected version of PR #3474.
In the old version, freebsd failed, because important imports were accidentally behind a linux-only macro.
This time I activate the github actions in my own namespace, they ran successful.
Please review!
Text from original issue:
When switching how you listen for battery plugging status events, the battery status will instantly update again!
Instead of inotify events on the /sys/class/.../ files, it is recommended to listen to udev netlink kernel events.
Closes #2444
Closes #2519
Might also
Closes #3726
Closes #3603
Closes #3471
I need aid implementing this, because I'm new to this project.
I will try to make this code look more like the backlight_backend, which also uses the udev netlink interfaces.