Remove `StopModules` from returned template import metadata #21206

Open

Assignees

opened

on Dec 10, 2025

Template imports return the modules found in both start and stop transitions.

coder/provisionerd/proto/provisionerd.proto

Lines 92 to 93 in 04bc86a

    
           repeated provisioner.Module start_modules = 6; 
        
           repeated provisioner.Module stop_modules = 7;

start & stop modules will never be different as count is ignored when downloading modules.

StopModules & StartModules should be moved to just modules.

Once #21064 is merged, the module source will be the same for both.

coder/provisionerd/runner/runner.go

Lines 609 to 612 in 04bc86a

    
           // TODO: These are defined as different, but can they be? 
        
           //   Terraform downloads modules regardless of `count`, so this should be the same 
        
           StartModules: initResp.Modules, 
        
           StopModules:  initResp.Modules,

Metadata

Assignees

Emyrk

Labels

No labels

No labels

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests