Add support for reading database connection details from a file #20962
Closed
rowansmithau
started this conversation in
Feature Requests
Replies: 1 comment
-
|
moved to #20963 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
This follows on from #19030.
Further testing with the customer has shown the issue to not be reproducible on a modern version of Coder, and after further discussion with Dean it was agreed the logical way to solve this problem was to offer an additional method of reading the database connection details from a file on disk. In addition to reading from the file on disk the implementation should include support for re-reading the contents of the file when initiating a new connection to the database in order to ensure new connections are always initiated using the most up to date credentials.
As testing has shown with minimal load there are still failed authentication attempts to the db when performing a rollout restart immediately after credentials are rotated this demonstrates though Coder uses db connection pools, it is not suitable to prevent a situation where old and invalid credentials are still attempted for use.
A potential implementation of this functionality could then be configured as follows:
Helm chart:
Preparation:
Beta Was this translation helpful? Give feedback.
All reactions